-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update 50 packages #79
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/bioc-rnaseq/compare/md-outputs..md-outputs-PR-79 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-09-05 16:15:36 +0000 |
Thanks @zkamvar! Just wanted to be sure - should the |
This is a weird thing that happens only in the pull request previews and I'm not sure why, but these actions are ultimately harmless as they always end up appearing in the correct places in the end. |
Ok, thanks! |
I think for the images, it's a bit confusing as to why they would disappear like that and I'm running the lesson locally now to see if that's a real problem or if that's an artefact of the PR process. One thing I would recommend is to use a package like {namer} to name the chunks: https://jumpingrivers.github.io/namer/ and then continue to name them as you go along. |
It looks like they appear locally, so it's likely a bug in the PR preview mechanism. |
👍🏻 And yes, totally agree about the naming, this was an oversight from my side - I'll update the chunks. |
Auto-generated via {sandpaper} Source : 047cf62 Branch : main Author : Charlotte Soneson <[email protected]> Time : 2023-09-05 17:19:07 +0000 Message : Merge pull request #79 from carpentries-incubator/znk/update/packages update 50 packages
Auto-generated via {sandpaper} Source : 3c789c8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-05 17:31:41 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 047cf62 Branch : main Author : Charlotte Soneson <[email protected]> Time : 2023-09-05 17:19:07 +0000 Message : Merge pull request #79 from carpentries-incubator/znk/update/packages update 50 packages
I've run the package update manually because the automated workflow was having trouble after the release of {renv} 1.0.0.
This brings in updates to 50 packages. Please wait for the output to run and then check for any new errors, warnings or surprising output changes.
I ran the following commands to update the cache with {renv} 1.0.2